Geo/soil test direct shear by indigocoral · Pull Request #13566 · KratosMultiphysics/Kratos

indigocoral · 2025-06-26T09:35:41Z

📝 Description
The GUI for the Element test has already been created. The triaxial test has also been added earlier. This issue aims at creating a direct shear test and also adding it to the GUI and being able to see the results plots.

🆕 Changelog

Build Direct Simple Shear test
Enabling the GUI to run the Direct Simple Shear test
Plotting the results
Reformat the file structures to be more generalized
Remove the tmp folder once the plotting is finished
Added Kratos logo to the UI
Added tests icon pictures to the UI
Added a label.py file to contain all the constants
Added pre-release license agreement
Added functionality to store the one-time agreement of the user
Added File and Help menu at the top
Added About section to the Help menu with Kratos and Deltares logos
Added title and the version number

…odification of the name of the file

…he name of the file

…+ modified the test suite name

WPK4FEM

Hi Marjan,
Thank you for all the good stuff here and for putting the used labels in a file and reusing them. I have some small comments in the test file setup and a remark about the direct shear picture. The code for the UI I have tried to understand, but failed due to my lack of experience with such programming. Luckily you have asked Richard to look at that too.
Regards, Wijtze Pieter

WPK4FEM · 2025-06-26T13:31:22Z

applications/GeoMechanicsApplication/python_scripts/element_test/assets/direct_shear.png

I wonder about the tau_xy indication in the picture. tau_xy is the shear stress that would appear on the contact of the 2 moving boxes in the picture. The test works with either a force or a prescribed displacement on the side which leads to a shear stress in the contact zone.

I'll try to fix that in the next PR.

WPK4FEM · 2025-06-26T13:52:19Z

...eoMechanicsApplication/python_scripts/element_test/test_direct_shear/MaterialParameters.json

+              "PERMEABILITY_YY"          :  4.5e-30,
+              "PERMEABILITY_XY"          :  0.0,
+              "DYNAMIC_VISCOSITY"        :  8.9e-07,
+              "THICKNESS"                :  1.0


Thickness is not needed in this plane strain computation.
Tables is empty and probably redundant.

WPK4FEM · 2025-06-26T13:57:17Z

...GeoMechanicsApplication/python_scripts/element_test/test_direct_shear/ProjectParameters.json

+                "model_part_name"      : "PorousDomain.Top_load",
+                "variable_name"        : "NORMAL_CONTACT_STRESS",
+                "active"               : [true,false],
+                "value"                : [0.0,0.0],
+                "fluid_pressure_type"  : "Uniform",
+                "table"                : [1,0]
+            }


As we have verically constrained the movement of the top nodes, this load disappears straight into the supports. We might omit it. The vertical stress comes from the next apply_initial_uniform_stress_field process.

WPK4FEM · 2025-06-26T13:58:10Z

...GeoMechanicsApplication/python_scripts/element_test/test_direct_shear/ProjectParameters.json

+                        "nodal_nonhistorical_results" : [],
+                        "gauss_point_results"         : ["CAUCHY_STRESS_TENSOR","VON_MISES_STRESS","MEAN_EFFECTIVE_STRESS","ENGINEERING_STRAIN_TENSOR"]
+                    },
+                    "point_data_configuration"  : []
+                },
+                "output_name"            : "gid_output/output"
+            }


Please remove the empty placeholders, I think we do not use them.

applications/GeoMechanicsApplication/python_scripts/element_test/test_direct_shear/mesh.mdpa

applications/GeoMechanicsApplication/python_scripts/element_test/plots.py

rfaasse

Nicely done, it works nicely and looking at the code it was added in a generic way (I expect adding the oedometer test would not be too difficult due to how extendible its setup is👍 ).

I have some suggestions, but nothing major. For me it's also still quite difficult to review due to being unfamiliar with the framework.

...GeoMechanicsApplication/python_scripts/element_test/test_direct_shear/ProjectParameters.json

applications/GeoMechanicsApplication/python_scripts/element_test/assets/icon.ico

rfaasse · 2025-06-27T09:05:45Z

applications/GeoMechanicsApplication/python_scripts/element_test/mdpa_editor.py

+
+    def update_middle_maximum_strain(self, maximum_strain):
+        pattern = r'\$middle_maximum_strain\b'
+        prescribed_middle_displacement = (-maximum_strain / 2) / 100


Just for my understanding, is this the average between the max and 0? To me it's not clear why we need a minus sign and why we need to divide by 100.

Ah.. yeah probably not a very clear coding from my side :D
The maximum strain will be taken from the user as an input in percentage. We need to divide by 100 to get the value. And then a minus sign (in Triaxial) was because we were applying compression. But here in the Direct Shear, I don't think it matters much which direction it gets applied because it is applied in X direction and we don't have any condition on the other side to make it matter from which side it should be applied. I won't change it now but will take a note to remember to maybe generalize it later.
Also, about the averaging, yes indeed. When setting up the Direct shear test, you have to apply the shear stress to the top half part of the soil model. We basically mimic that by applying the half amount of the shear strain to the middle points. Hope this is clear.

The shear strain and shear stress ( like any other strain or stress ) are uniform in these tests. To get such a uniform strain the motion of the nodes is prescribed such that the bottom nodes do not move, the top nodes move all with the same distance and the nodes at half the height of the specimen move half the distance of the top nodes.

Clear, I missed the '%' that is clearly there in the GUI and the rest is clear from both your explanations

applications/GeoMechanicsApplication/python_scripts/element_test/plots.py

applications/GeoMechanicsApplication/python_scripts/element_test/run_simulation.py

applications/GeoMechanicsApplication/python_scripts/element_test/ui_runner.py

applications/GeoMechanicsApplication/python_scripts/element_test/test_direct_shear/mesh.mdpa

applications/GeoMechanicsApplication/python_scripts/element_test/ui_builder.py

… the axis range once sigma_1 and sigma_3 are close together

…ult maximum_strain to 20%

…ion number to the title

…part

…eters

rfaasse

Thanks for processing the review comments! I have a few comments left, but most of them are not for changes that need to be done right now.

I think after this v0.1.0 release, we should have a discussion with the team to determine what exactly the direction and our requirements are for this GUI and the extensions we want to make. There are for example design patterns regarding GUIs to make it more maintainable and split the logic (of running and calculating things) with displaying everything (these are patterns like Model-View-Control or Model-View-Viewmodel).

Right now I don't have the overview (both on direction and the current code) on if it would be necessary to do some restructuring there or if it's already fit for everything we want it to be able to do (mainly in the future).

For now, well done, I think we're almost there!

rfaasse · 2025-07-03T11:44:31Z

applications/GeoMechanicsApplication/python_scripts/element_test/ui_builder.py

+        self.test_type_menu = ttk.Combobox(
+            parent,
+            textvariable=self.test_type_var,
+            values=["Drained"],


I'm not too sure if we need to have this drop-down with a single value (since we've only got 'Drained'). Given the time-frame, let's leave it as is for now, but in general my opinion it's better not to add more functionality than needed in the future.

This was requested and it is to show the user what type of test this is. For now we have "Drained" only, but more options will have to be added later, like: "Undrained", etc...

rfaasse · 2025-07-03T11:51:41Z

applications/GeoMechanicsApplication/python_scripts/element_test/ui_menu.py

+
+
+
+def show_license_agreement():


Not for now, but I'd prefer to have this in a separate plain resource txt file somewhere in a later PR

rfaasse · 2025-07-03T11:57:33Z

applications/GeoMechanicsApplication/python_scripts/element_test/ui_menu.py

+    if not os.path.exists(LICENSE_FLAG_PATH):
+        show_license_agreement()


This means it doesn't really matter what's in the file right? I'm not sure if that would matter. Of course people can circumvent this by just creating that file themselves, but I don't think that should be an issue, since they also would just have access to the python files, so they can do what they want

I mean... Yes :D

rfaasse · 2025-07-03T11:59:55Z

applications/GeoMechanicsApplication/python_scripts/element_test/ui_menu.py

+        license_window.destroy()
+
+    def decline():
+        messagebox.showinfo("Exit", "You must accept the license agreement to use this software.")


If you close the license popup, the application will crash instead of showing this exit message (not a blocker, but maybe something to fix in the future)

rfaasse · 2025-07-03T12:00:29Z

applications/GeoMechanicsApplication/python_scripts/element_test/ui_menu.py

+        license_window.destroy()
+
+    def decline():
+        messagebox.showinfo("Exit", "You must accept the license agreement to use this software.")


Also it's interesting you can decline it after you already accepted it before, but that's also fine for now in my opinion

rfaasse · 2025-07-03T12:19:13Z

applications/GeoMechanicsApplication/python_scripts/element_test/mdpa_editor.py

+
+    def update_middle_maximum_strain(self, maximum_strain):
+        pattern = r'\$middle_maximum_strain\b'
+        prescribed_middle_displacement = (-maximum_strain / 2) / 100


Clear, I missed the '%' that is clearly there in the GUI and the rest is clear from both your explanations

rfaasse

Good to go!

indigocoral added 16 commits June 17, 2025 17:14

modified triaxial mesh file name and output file name

4393d82

added the direct shear test files

6eec8ca

added the functionality for updating middle displacement in mdpa

010c9c7

added direct shear test plots + unifying it with triaxial

12bd389

modified the run_simulation function to include direct shear test + m…

431340f

…odification of the name of the file

modified the TestRunner to include direct shear test + generalizing t…

35b1522

…he name of the file

triaxial mesh file

5713ceb

generalizing the ui runner

c5d6eea

modified the ui_builder.py to include the direct shear test

54f53d0

added Kratos logo and tests icons to the test

6319909

added taskbar icon picture, replaced png with ico file

92d4d9d

improved icon quality + removal of some spaces

b35a3c8

added ui_labels.py to store all the labels + fixed SonarCloud issues …

475cb9a

…+ modified the test suite name

remove the temporary folder after plotting is finished

c671ba1

small adjustment for the resolution

d8d0643

refactored run_simulation.py to fix SonarCloud issue

45edbd8

indigocoral requested a review from a team as a code owner June 26, 2025 09:35

indigocoral self-assigned this Jun 26, 2025

indigocoral added the GeoMechanics Issues related to the GeoMechanicsApplication label Jun 26, 2025

indigocoral requested review from WPK4FEM and rfaasse June 26, 2025 09:36

WPK4FEM previously approved these changes Jun 26, 2025

View reviewed changes

rfaasse reviewed Jun 27, 2025

View reviewed changes

indigocoral added 4 commits July 2, 2025 09:22

modified the Mohr-Coulomb plot for Direct Simple Shear test to adjust…

3ad38ec

… the axis range once sigma_1 and sigma_3 are close together

removed the default values for MohrCoulomb64.dll and changed the defa…

b4c1c26

…ult maximum_strain to 20%

changed "Select DLL File" to "Select UDSM File"

5f2a84f

added one-time pre-release license agreement to GUI + adding the vers…

19668e4

…ion number to the title

indigocoral dismissed WPK4FEM’s stale review via 19668e4 July 2, 2025 07:36

indigocoral added 2 commits July 2, 2025 15:20

added menu to the GUI + about section with Kratos and Deltares logos

52e51ab

small adjustment to the Mohr-coulomb plot

4fa31a0

indigocoral added 12 commits July 2, 2025 16:19

added test type "Drained"

c806610

added the Title and the Version number as a label

122ce10

modified the MaterialParameters.json

c6be8dd

removed the "Top_load" modelpart from Direct Shear

4eb9313

adjusted the Direct Shear test to the removal of the "Top_load" model…

f47e3c0

…part

changed the flag directory to AppData

f9423f0

added the name label for the flag

7b9331f

removed unnecessary part

9d26b86

unified the log_message warnings

92bca78

applying review comments - renaming umat_parameters to material_param…

96cf1c9

…eters

applying more review comments - tidying the ProjectParameters.json files

0d79b13

applying more review comments - tidying the mesh.mdpa

015e58d

rfaasse previously approved these changes Jul 3, 2025

View reviewed changes

indigocoral added 2 commits July 3, 2025 16:06

applying more review comments - index handling

76b88e6

fixing SonarCloud issue with font repetition

6270054

indigocoral dismissed rfaasse’s stale review via 6270054 July 3, 2025 14:07

rfaasse approved these changes Jul 4, 2025

View reviewed changes

indigocoral merged commit bde18dc into master Jul 4, 2025
21 of 22 checks passed

indigocoral deleted the geo/soil_test_direct_shear branch July 4, 2025 09:17

		if not os.path.exists(LICENSE_FLAG_PATH):
		show_license_agreement()

Conversation

indigocoral commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WPK4FEM left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rfaasse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rfaasse left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rfaasse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

indigocoral commented Jun 26, 2025 •

edited

Loading