PR for solid elements and conditions in IGA #13520
Merged
Conversation
…into PR_solid_element_IGA
…into PR_solid_element_IGA
NickNick9
reviewed
Jun 16, 2025
Contributor
NickNick9
left a comment
NickNick9
left a comment
There was a problem hiding this comment.
only these small details
applications/IgaApplication/custom_conditions/load_solid_condition.cpp
Outdated
Show resolved
Hide resolved
|
|
||
| const double thickness = GetProperties().Has(THICKNESS) ? GetProperties()[THICKNESS] : 1.0; | ||
|
|
||
| const double IntToReferenceWeight = r_integration_points[0].Weight() * std::abs(DetJ0) * thickness; |
| // Initialize Jacobian | ||
| GeometryType::JacobiansType J0; | ||
| // Initialize DN_DX | ||
| const unsigned int dim = 2; |
Contributor
There was a problem hiding this comment.
can you create a member variables or something like that for the dimension?
| // Set constitutive law flags: | ||
| Flags& ConstitutiveLawOptions=Values.GetOptions(); | ||
|
|
||
| ConstitutiveLawOptions.Set(ConstitutiveLaw::USE_ELEMENT_PROVIDED_STRAIN, true); |
Contributor
There was a problem hiding this comment.
I would also create a function here: ApplyConstitutiveLaw
NickNick9
previously approved these changes
Jun 17, 2025
…into PR_solid_element_IGA
NickNick9
previously approved these changes
Jun 17, 2025
NickNick9
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Addition of element, Dirichlet and Neumann conditions for the solid element 2D in the IgaApplication
Please mark the PR with appropriate tags:
🆕 Changelog
Addition of element, Dirichlet and Neumann conditions for the solid element 2D in the IgaApplication