Skip to content

Fix Acusolve global sequence#13513

Merged
ghanique-altair merged 2 commits intomasterfrom
feature/acusolve-wrapper
Jul 23, 2025
Merged

Fix Acusolve global sequence#13513
ghanique-altair merged 2 commits intomasterfrom
feature/acusolve-wrapper

Conversation

@ghanique-altair
Copy link
Contributor

📝 Description
This new version of the Acusolve wrapper fixes the global Acusolve sequence when integrated in the Kratos cosimulation orchestrator.

It includes some other minor bug fixes, especially to deal with Linux version.

🆕 Changelog

  • Fix Acusolve integration in Kratos orchestrator

loumalouomega
loumalouomega previously approved these changes Jun 12, 2025
Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve, but i would rather use the CoSim Logger instead of python prints

# - RepeatTimeStep
# - AdvanceInTime
# - exit
print("{} :: Sending signal : {}".format(self.name,signal))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print("{} :: Sending signal : {}".format(self.name,signal))
print(f"{self.name} :: Sending signal : {signal}")

Same for other formatted strings.

@ghanique-altair
Copy link
Contributor Author

@loumalouomega, Prints are now done by using CoSim Logger.

@ghanique-altair ghanique-altair merged commit 879170d into master Jul 23, 2025
10 checks passed
@ghanique-altair ghanique-altair deleted the feature/acusolve-wrapper branch July 23, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants