Skip to content

[Core] Avoid Ublas namespace polluting with explicit call in array_1d#13509

Merged
loumalouomega merged 1 commit intomasterfrom
core/ublas-pollluting-modelpartio-array1d
Jun 21, 2025
Merged

[Core] Avoid Ublas namespace polluting with explicit call in array_1d#13509
loumalouomega merged 1 commit intomasterfrom
core/ublas-pollluting-modelpartio-array1d

Conversation

@loumalouomega
Copy link
Member

📝 Description

I just realized that Ublas is polluting our namespace. This is going to be problematic in a future if we want to get rid of Ublas. In here I explicitily call Ublas so in a future refactoring will be easier to identify the Ublas use.

🆕 Changelog

@loumalouomega loumalouomega requested a review from roigcarlo June 10, 2025 08:42
@loumalouomega loumalouomega requested a review from a team as a code owner June 10, 2025 08:42
@loumalouomega loumalouomega added Cleanup Kratos Core External library FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Jun 10, 2025
@loumalouomega loumalouomega enabled auto-merge June 10, 2025 08:43
@loumalouomega loumalouomega merged commit de8f669 into master Jun 21, 2025
11 checks passed
@loumalouomega loumalouomega deleted the core/ublas-pollluting-modelpartio-array1d branch June 21, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup External library FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants