Merged
Conversation
markelov208
previously approved these changes
Dec 19, 2024
Contributor
markelov208
left a comment
markelov208
left a comment
There was a problem hiding this comment.
Hi Wijtze-Pieter, it looks like the users are heavily use this functionality. Thank you very much for adding new checks that are unit tested. I have two non-blocking comments.
applications/GeoMechanicsApplication/custom_processes/apply_c_phi_reduction_process.cpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_processes/apply_c_phi_reduction_process.cpp
Show resolved
Hide resolved
WPK4FEM
force-pushed
the
geo/error-checking-c-phi-reduction
branch
from
be782fa to
cedf75c
Compare
avdg81
approved these changes
Dec 20, 2024
Contributor
avdg81
left a comment
avdg81
left a comment
There was a problem hiding this comment.
This looks more robust to me now. I have no further comments or suggestions. Let's merge it when it's ready.
markelov208
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Extra errors and unit tests for those checks for K0 and C-Phi