Conversation
ddiezrod
changed the title
Member
|
But isn't this what @loumalouomega fixed yesterday? |
Author
|
@rubenzorrilla upss yeah, I did not see it, well I'd merge this instead as it also adds a test that covers the bug... |
Member
|
I'd leave the other one, which is about to be automerged, to then update the corresponding tests in this one (after merging the master OFC). |
Author
|
@rubenzorrilla Done. I have to say, I'm not a fan of adding so many obvious comments to the code, but I'll let it slide this time. 😄 |
Member
|
rubenzorrilla
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems this was removed by mistake on the latest PR (#12700) , so now the dof set is being rebuilt at every time step!
ping @jrubiogonzalez as he was the one that found the error.