[Fluid] Move BlockSize to data containers#12938
Merged
rubenzorrilla merged 10 commits intomasterfrom Dec 13, 2024
Merged
Conversation
Member
|
Thanks for fixing the error, it was just a small mistake. I did not used that variable. |
Member
Author
Yes. It was silently there, the point is that with this change it woke up 😄 . Nevertheless, just for you to know. |
Member
Author
|
Note that last bunch of commits only remove the redundant |
RiccardoRossi
previously approved these changes
Dec 13, 2024
6f11bdb to
b0013b8
Compare
roigcarlo
approved these changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
In this PR I'm moving the
BlockSizestatic constexpr variable from theFluidElementbase class to the data containers. This will make possible to use current element inheritance structure with formulations featuring unknowns different to u-p (e.g., thermally coupled ones). Also note that I took the chance to move the data containers fromcustom_utilitiesfolder to thedata_containersone together to the element.@jgonzalezusua note that you had an error in the block size definition in your DEM coupled element. As far is I see you were not using that one but the one from the base element. In any case, take this observation into account just in case.
@uxuech note that this will affect your new elements when merging the master (you need to do the corresponding changes mimicking the ones in here in your branch).