[CMake] Defaulting the coloring of the Logger#12927
Merged
loumalouomega merged 1 commit intomasterfrom Dec 17, 2024
Merged
Conversation
loumalouomega
added
Kratos Core
FastPR
roigcarlo
reviewed
Dec 17, 2024
Member
roigcarlo
left a comment
roigcarlo
left a comment
There was a problem hiding this comment.
Won't this print a lot of noise if run on terminals with no support for colors?
Sorry to ask but I am completely clueless about the implementation of this feature.
Member
Author
Right, I can just sinly put it in false by default, but until now was there but hidden. |
Member
|
Pls |
Member
|
Well if it was there already and was enabled by default ok. (I was not aware if it) |
roigcarlo
approved these changes
Dec 17, 2024
Member
Author
Huum, i was cahnging it, a priori was not defaulted, I can change the default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Defaulting the coloring of the
Logger.🆕 Changelog
Logger