[Core] Geometry based connectivity preserve modeler#12794
Merged
rubenzorrilla merged 18 commits intomasterfrom Nov 25, 2024
Merged
[Core] Geometry based connectivity preserve modeler#12794rubenzorrilla merged 18 commits intomasterfrom
rubenzorrilla merged 18 commits intomasterfrom
Conversation
loumalouomega
previously approved these changes
Oct 26, 2024
…sed-connectivity-preserve-modeler
Member
Author
|
@loumalouomega I think that now that #12843 is merged this is ready to go as well. |
Member
Oki |
Member
I can approve it if you consider me worthy of that |
Member
Author
I think so (you know this class and you're also using it in your side). Note that I reverted the undesired changes from the other branch. |
loumalouomega
approved these changes
Nov 25, 2024
rubenzorrilla
deleted the
core/geometry-based-connectivity-preserve-modeler
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This extends current capabilities of the
ConnectivityPreserveModelerto consider geometries. Also note that if neither element type nor condition are provided, now we apply theConnectivityPreserveModelerwith nodes and conditions (before we used to throw an error). This makes possible to leverage this model in the geometry-based I/O (e.g., CHT or buoyancy).