additional SBM features to nurbs_curve_on_surface_geometry#12717
additional SBM features to nurbs_curve_on_surface_geometry#12717
Conversation
Co-authored-by: andrewgorgi <andrewgorgi@users.noreply.github.com>
| const double tolerance_intersection = 1e-15; | ||
|
|
||
| // Scale factor between volume coordinate and surface one | ||
| double physical_length_segment = norm_2(physical_coord_1-physical_coord_2); |
rubenzorrilla
left a comment
There was a problem hiding this comment.
I need to do a further review, but at first glance, I'm not a big fan of adding a geometry that depends on the method... In other words, I don't really like the IS_SBM stuff. Can you please justify its need?
|
@rubenzorrilla > I need to do a further review, but at first glance, I'm not a big fan of adding a geometry that depends on the method... In other words, I don't really like the @NickNick9 So my reason is: SBM and IBRA conceptually are very similar, we want a flag that says which approach you want to use when you have to deal with the un-fitted boundary in IGA. |
rubenzorrilla
left a comment
There was a problem hiding this comment.
Overall makes sense. Nevertheless, I'd indicate the upcoming changes with code comments. Specially the unification of the SBM and the untrimmed cases, which is something that IMO must be done for sure (most probably in a future PR).
kratos/tests/cpp_tests/geometries/test_nurbs_curve_on_surface_geometry.cpp
Outdated
Show resolved
Hide resolved
kratos/tests/cpp_tests/geometries/test_nurbs_curve_on_surface_geometry.cpp
Outdated
Show resolved
Hide resolved
kratos/tests/cpp_tests/geometries/test_nurbs_curve_on_surface_geometry.cpp
Outdated
Show resolved
Hide resolved
kratos/tests/cpp_tests/geometries/test_nurbs_curve_on_surface_geometry.cpp
Outdated
Show resolved
Hide resolved
kratos/tests/cpp_tests/geometries/test_nurbs_curve_on_surface_geometry.cpp
Outdated
Show resolved
Hide resolved
Did you already add the comments I mentioned in here? (I did not find them). |
rubenzorrilla
left a comment
There was a problem hiding this comment.
All my initial concerns have been addressed (aside of the unification of the traditional and SBM integration points creation, which will be done in an upcoming PR).
📝 Description
We have added to the nurbs_curve_on_surface_geometry the possibility of considering an SBM brep surface.
Instead of using the method ComputeAxisIntersection, in the SBM case we use a different one called ComputeAxisIntersectionSBM (that only looks for intersections on the knot vertices).
Moreover, we have also added the SBM case in the CreareQuadraturePoints method in the same file.
IgaApplication
Geometry