Conversation
| } | ||
|
|
||
| if (p < 0) | ||
| return false; // in this case the square roots below will be negative. This substitutes with better efficiency lines 107-110 |
There was a problem hiding this comment.
This one I changed since due to the clang-formatting the lines shifted
| * | ||
| */ | ||
|
|
||
| class GeoStaticCondensationUtility |
There was a problem hiding this comment.
It seems this was copied from structural mechanics, we might just be able to re-use that one.
markelov208
left a comment
markelov208
left a comment
There was a problem hiding this comment.
Hi Richard, thank you for the quick improvements. Just one comment on Portuguese. Is it a correct translation? Kind regards,
| @@ -712,8 +667,8 @@ class GeoMechanicsMathUtilities | |||
| static inline void TensorToMatrix(Fourth_Order_Tensor& Tensor, Matrix& Matrix) | |||
| { | |||
| // Simetrias seguras | |||
There was a problem hiding this comment.
Shall it be 'Safe symmetries'? ;)
There was a problem hiding this comment.
I tried to translate the meaning, good point!
avdg81
left a comment
avdg81
left a comment
There was a problem hiding this comment.
This is a small, but clear PR that reduces the amount of clutter and dirt. Thank you for taking this up.
| using VectorType = Vector; | ||
| using IndexType = unsigned int; | ||
| using SizeType = unsigned int; | ||
| using Fourth_Order_Tensor = DenseVector<DenseVector<Matrix>>; |
There was a problem hiding this comment.
Perhaps for consistency, we should rename this alias to FourthOrderTensorType?
There was a problem hiding this comment.
I would propose to remove all unused functions from this file after you have merged this PR.
| * | ||
| */ | ||
|
|
||
| class GeoStaticCondensationUtility |
avdg81
left a comment
avdg81
left a comment
There was a problem hiding this comment.
I feel this one is good to go.
3 participants
During the formatting of the custom elements, we found quite some commented code which we would like to remove. As a quick win, I also changed typedefs to usings (and removed some unused ones) in the files I touched anyway.