[Core] Improve performance in GenerateEntitiesFromConnectivities#12348
Conversation
pooyan-dadvand
left a comment
There was a problem hiding this comment.
Do you have any comparison of the speed for large number of elements?
Yes, compared with manually adding (in C++) is twice as fast and with previous version is many times faster. |
|
@roigcarlo do you think we can do a patch for the relase?, kind of 9.5.1? |
|
If you need one done yes absolutely |
Yes, thanks, we are interested on this |
|
@loumalouomega I would first pass a provisional binary to see if this is really fixed and then we would ask for a hot fix |
Okay I will generate the binaries for them |
📝 Description
Improve performance in
GenerateEntitiesFromConnectivities, avoidinsert, usingpush_backinstead. NOTE: In my mind insert was faster because I thought it did all at once.🆕 Changelog
insert, usingpush_backinstead.