[GeoMechanicsApplication] Add 1D functionality to the existing 2D/3D thermal element#12303
[GeoMechanicsApplication] Add 1D functionality to the existing 2D/3D thermal element#12303mnabideltares merged 11 commits intomasterfrom
Conversation
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
This is a very nicely scoped change, which makes it easy to review. I have some minor suggestions and questions, but I would suggest to merge this one first, before the Pw element
applications/GeoMechanicsApplication/custom_elements/transient_thermal_element.h
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_elements/transient_thermal_element.h
Show resolved
Hide resolved
WPK4FEM
left a comment
WPK4FEM
left a comment
There was a problem hiding this comment.
Dear Mohammed,
Thank you for this short and effective implementation. Apart from the remarks I made, please add the extra tests you made in some way to the README you made for the other thermal elements.
Wijtze Pieter
applications/GeoMechanicsApplication/custom_constitutive/thermal_dispersion_law.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_elements/transient_thermal_element.h
Show resolved
Hide resolved
avdg81
left a comment
avdg81
left a comment
There was a problem hiding this comment.
A very nice and clean extension of your previous work. Well done! I only have a few minor comments.
applications/GeoMechanicsApplication/custom_elements/transient_thermal_element.cpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_elements/transient_thermal_element.h
Outdated
Show resolved
Hide resolved
...test_thermal_line_element/test_thermal_line_element_2D2N/test_thermal_line_element_2D2N.mdpa
Outdated
Show resolved
Hide resolved
...mal_element/test_thermal_line_element/test_thermal_line_element_3D2N/MaterialParameters.json
Outdated
Show resolved
Hide resolved
...rmal_element/test_thermal_line_element/test_thermal_line_element_3D2N/ProjectParameters.json
Outdated
Show resolved
Hide resolved
...test_thermal_line_element/test_thermal_line_element_3D2N/test_thermal_line_element_3D2N.mdpa
Outdated
Show resolved
Hide resolved
...mal_element/test_thermal_line_element/test_thermal_line_element_3D3N/MaterialParameters.json
Outdated
Show resolved
Hide resolved
...rmal_element/test_thermal_line_element/test_thermal_line_element_3D3N/ProjectParameters.json
Outdated
Show resolved
Hide resolved
Added README.md for the test cases
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
Thank you for processing the review comments and adding the readme for the tests, this turned out a very comprehensive PR!
I have one minor comment to add some clarification for what the test actually asserts, next to the illustrative graph you added, but other than that I think we're good to go!
...tions/GeoMechanicsApplication/tests/test_thermal_element/test_thermal_line_element/README.md
Show resolved
Hide resolved
avdg81
left a comment
avdg81
left a comment
There was a problem hiding this comment.
Thank you so much for processing the review comments. Your extension is clear, clean, well-tested and well-documented. I only have one minor (non-blocking) comment.
...tions/GeoMechanicsApplication/tests/test_thermal_element/test_thermal_line_element/README.md
Show resolved
Hide resolved
WPK4FEM
left a comment
WPK4FEM
left a comment
There was a problem hiding this comment.
For me this looks ready to merge.
…thermal element (#12303) * Added thermal line element * Fixed a bug * Added test cases * Added 3D thermal line element + test cases * modifications based on review 3 Added README.md for the test cases * fix for documentation * Modifications based on review 3 * Modifications based on review 4 * improvements in README * Fix in README.md for units * A small fix
4 participants
📝 Description
The objective of this issue is to design a well-element, which is inherently a line element. It has large similarities with the thermal line element, except the constutative law and the way of handeling with geometrical parameters such as Jacobian. So, it can be considered as an extention in capabilities of the existing thermal element.
In oder to avoid duplication in the code, we decided to used the existing thermal element, and extend its capability to handle with the line elementas. To make it more generic and resonable, the thermal element needs to be extended to be able to solve the standard case in 1D. Then the well-element can be added on the top of it.
🆕 Changelog