[GeoMechanicsApplication] Add 1D functionality to existing 2D/3D Pw element

[mnabideltares]

📝 Description
As user we would like to implement well-element for geothermal high capacity heat storage. For this, we need 1D pressure and thermal elements. However, 1D pressure element does not exist in the current implementation.

Here, we would like to add a generic 1D pressure line element (to be used for well-element in the later implementation).

🆕 Changelog

• Added pressure line element class, inherited directly from Element class.
• Registered the elements
• Added test cases

[markelov208]

Hi Mohamed, a great work and many tests added. I put some comments. It looks that we have already implemented similar things.

[rfaasse]

This is nicely added as derived from the Element class and does not add to the hierarchy tree we are trying to clean up!

There are still some duplications in here that I think we should be able to clean up. We can have a discussion what would be the best way to do this (we could for example create a small PR to extract some functionality to a utility function, such that we can re-use it here and in the other places where we have defined some of these functions.

[markelov208]

Hi Mohamed, many thanks for the conversation and fixing the code. Let's move on ;)

[WPK4FEM]

Dear Mohammed,
Not sure if all my remarks on the code should be taken up. However, I find it quite important to have follow up on some of the remarks on tests. 3D is unintentionally using 2D elements.
Regards, Wijtze Pieter

[WPK4FEM]

Very readable, like a formula.
The name of the function however says AddContributionsTo. That is not what this formula states.

[WPK4FEM]

Same here: very readable like a formula.
The function name AddContributionsTo sounds like += i.s.o. the =

[rfaasse]

Thanks a lot for all your efforts in processing review comments and adding the documentation, I have one question left about the tangential vector, but next to the open comments from Wijtze Pieter, I have nothing to add!

[rfaasse]

Looks good to me!

[WPK4FEM]

Lets go and in a separate commit make naming for LHS and RHS computation consistent in both Pw and T elements.

[WPK4FEM]

Is RESIDUAL_SATURATION needed for the SaturatedLaw? The 3D materials parameters files shows that it is possible without.