Skip to content

[Core] Remove deprecated warning#11777

Merged
loumalouomega merged 2 commits intomasterfrom
core/remove-deprecated-warning
Nov 10, 2023
Merged

[Core] Remove deprecated warning#11777
loumalouomega merged 2 commits intomasterfrom
core/remove-deprecated-warning

Conversation

@loumalouomega
Copy link
Member

📝 Description

Remove deprecated warning

🆕 Changelog

@loumalouomega loumalouomega added Warning Cleanup Kratos Core FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Nov 8, 2023
@loumalouomega loumalouomega requested a review from a team as a code owner November 8, 2023 14:27
Copy link
Member

@philbucher philbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is even worse than using the default, why not using Testing::GetDefaultDataComm?

@loumalouomega
Copy link
Member Author

That is even worse than using the default, why not using Testing::GetDefaultDataComm?

Because I din't know thatw as the alternative

@loumalouomega loumalouomega merged commit d0fab22 into master Nov 10, 2023
@loumalouomega loumalouomega deleted the core/remove-deprecated-warning branch November 10, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core Warning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants