[GeoMechanicsApplication] Fixed a bug related to handling of conditions#11765
Merged
[GeoMechanicsApplication] Fixed a bug related to handling of conditions#11765
Conversation
WPK4FEM
previously approved these changes
Nov 3, 2023
Contributor
WPK4FEM
left a comment
WPK4FEM
left a comment
There was a problem hiding this comment.
Tiny improvement is adding the forgotten unit in the README file
applications/GeoMechanicsApplication/tests/line_load_tests/line_loads_in_stages/README.md
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/test_settlement_workflow/test_model.mdpa
Show resolved
Hide resolved
WPK4FEM
previously approved these changes
Nov 3, 2023
rfaasse
previously approved these changes
Nov 3, 2023
Contributor
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
Clear PR, good find! Just two (non-blocking) comments.
avdg81
force-pushed
the
geo/fix-condition-handling
branch
from
d524a1a to
46d2e24
Compare
We have found that conditions were only added to the computational model
part, but never removed from it. In multi-stage analysis, that could
result in adding inactive loads from previous stages. That has been
corrected.
Other changes include:
- Added a simple regression test with two uniform line loads, where each
one is active in its own stage.
- Added a static method to Python class `GiDOutputFileReader`, which
returns a list of nodal result values at the given time. Optionally,
it filters its result given a sequence of node IDs.
- Use `math.isclose` to test whether two given times are nearly equal
rather than using `==`.
- Removed some duplicated conditions that had been created by GiD.
- Updated the expected results of the settlement work flow test.
- Added a few nodal results that can be written by class
`GeoOutputWriter`: reaction forces, normal contact stresses, and
tangential contact stresses.
- Files `write_output.{cpp,h}` have been renamed to
`geo_output_writer.{cpp,h}`.
avdg81
force-pushed
the
geo/fix-condition-handling
branch
from
46d2e24 to
b4d8b5b
Compare
rfaasse
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
We have found that conditions were only added to the computational model part, but never removed from it. In multi-stage analysis, that could result in adding inactive loads from previous stages. That has been corrected.
🆕 Changelog
Other changes include:
GiDOutputFileReader, which returns a list of nodal result values at the given time. Optionally, it filters its result given a sequence of node IDs.math.iscloseto test whether two given times are nearly equal rather than using==.GeoOutputWriter: reaction forces, normal contact stresses, and tangential contact stresses.