[Core] Defines ObjectType and PointType in GeometricalObjectsBins#11731
Merged
loumalouomega merged 3 commits intomasterfrom Oct 30, 2023
Merged
[Core] Defines ObjectType and PointType in GeometricalObjectsBins#11731loumalouomega merged 3 commits intomasterfrom
ObjectType and PointType in GeometricalObjectsBins#11731loumalouomega merged 3 commits intomasterfrom
Conversation
loumalouomega
added
Kratos Core
Typo
FastPR
loumalouomega
changed the title
ObjectType in GeometricalObjectsBinsObjectType and PointType in GeometricalObjectsBins
roigcarlo
approved these changes
Oct 30, 2023
| KRATOS_CLASS_POINTER_DEFINITION(GeometricalObjectsBins); | ||
|
|
||
| /// The point type definition | ||
| using PointType = Point; |
Member
There was a problem hiding this comment.
I will approve, but I don't understand. Why do you want to make this type an alias, if you are hard-coding it here?
I assume it is because you are going to use this as a base of another bins?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Defines
ObjectTypeandPointTypeinGeometricalObjectsBins. Minor typo corrected as well.🆕 Changelog
ObjectTypeinGeometricalObjectsBinsPointTypedefinition