Merged
Conversation
roigcarlo
approved these changes
Oct 24, 2023
Member
roigcarlo
left a comment
roigcarlo
left a comment
There was a problem hiding this comment.
If intel keeps running all good to me. I guess the only way to see is merging it.
I'll be watching for PR today to se how it behaves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only install the new intel compiler to reduce the size. I will remove the legacy intel build in a follow-up PR
EDIT remove valgrind, and install sudo to support installations in CI (need this for some experimentation)
hopefully helps with #11566