[Core][MPI] Adding MinLocAll and MaxLocAll to DataCommunicator

[loumalouomega]

📝 Description

Adding MinLocAll and MaxLocAll to DataCommunicator. This function not only computes the maximum/minimum but the partition where this values is local.

I also changed the suite in the serial DataCommunicator tests, as it was wrong,

🆕 Changelog

• Adding MinLocAll and MaxLocAll to DataCommunicator
• Tests added
• Corrected the suite for the data communicator (serial)

[jcotela]

I am not convinced by the change of suite of the data_communicator tests but fair enough if people thinks it makes sense.

I would suggest to put all the logic for MPI datatype deduction on one place (mpi_message).

Other than that, looks good to me

[jcotela]

I changed it a bit so that MinLoc and MaxLoc are not defined for array/vector types, as I think they would not make sense with the current implementation (min/max by component, so that the result can be a composite of the values from different partitions). If this is not desirable, my preference would be to revert cde37b7 and bb95bac and keep @loumalouomega's original implementation.

[RiccardoRossi]

could u document what the funciton returns possibly in its signature?

is it (value, rank) or something different?

[loumalouomega]

could u document what the funciton returns possibly in its signature?

is it (value, rank) or something different?

It is an std::pair of value, int

[loumalouomega]

could u document what the funciton returns possibly in its signature?

is it (value, rank) or something different?

Documentation added

[loumalouomega]

Feel free to approve @jcotela

[loumalouomega]

Feel free to approve @jcotela

?

[philbucher]

please add a python test as well then I approve

[loumalouomega]

please add a python test as well then I approve

Done