Skip to content

[Core] Unify SearchUtilities#11710

Merged
loumalouomega merged 13 commits intomasterfrom
Core/unify-search-utilities
Nov 8, 2023
Merged

[Core] Unify SearchUtilities#11710
loumalouomega merged 13 commits intomasterfrom
Core/unify-search-utilities

Conversation

@loumalouomega
Copy link
Member

@loumalouomega loumalouomega commented Oct 23, 2023

📝 Description

As there is no direct MPI dependency in the MPISearchUtilities, onlyDatacommunicator, I move the code to the core so it can be reused in serial/MPI without MPICore dependency.

🆕 Changelog

@loumalouomega loumalouomega added Kratos Core Parallel-MPI Distributed memory parallelism for HPC / clusters FastPR This Pr is simple and / or has been already tested and the revision should be fast Refactor When code is moved or rewrote keeping the same behavior labels Oct 23, 2023
@loumalouomega loumalouomega requested review from a team as code owners October 23, 2023 09:23
@loumalouomega
Copy link
Member Author

loumalouomega commented Oct 23, 2023

Cloasing #11689 as it is included here

@loumalouomega
Copy link
Member Author

loumalouomega commented Oct 25, 2023

@philbucher intel compiler is failing: https://github.com/KratosMultiphysics/Kratos/actions/runs/6638261215/job/18034253599?pr=11710

@loumalouomega loumalouomega mentioned this pull request Oct 25, 2023
Open
@loumalouomega
Copy link
Member Author

loumalouomega commented Nov 6, 2023

@pooyan-dadvand @roigcarlo

@loumalouomega
Copy link
Member Author

loumalouomega commented Nov 8, 2023 •
edited
Loading

This is the only pending transition PR for #11719, can you check @roigcarlo ?

@roigcarlo
Copy link
Member

roigcarlo commented Nov 8, 2023

On it

roigcarlo
roigcarlo approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@roigcarlo roigcarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Fine, I just wanted to make sure there were no mpi dependencies after changing the utlities, but I forgot it existed.

All right!

@loumalouomega loumalouomega merged commit 8ab0586 into master Nov 8, 2023
@loumalouomega loumalouomega deleted the Core/unify-search-utilities branch November 8, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roigcarlo roigcarlo roigcarlo approved these changes

@pooyan-dadvand pooyan-dadvand Awaiting requested review from pooyan-dadvand

Assignees

No one assigned

Labels

FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core Parallel-MPI Distributed memory parallelism for HPC / clusters Refactor When code is moved or rewrote keeping the same behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loumalouomega @roigcarlo