[Core] Extend CppTestsUtilities with CreateCubeSkinModelPart and CreateCubeModelPart#11697
Merged
loumalouomega merged 4 commits intomasterfrom Oct 18, 2023
Merged
Conversation
…`CreateCubeModelPart`
loumalouomega
added
Kratos Core
C++
Testing
FastPR
loumalouomega
changed the title
CppTestsUtilities with CreateCubeSkinModelPart and CreateCubeModelPartCppTestsUtilities with CreateCubeSkinModelPart and CreateCubeModelPart
roigcarlo
reviewed
Oct 18, 2023
| ///@name Kratos Classes | ||
| ///@{ | ||
| // forward declaring ModelPart to be avoid including heavy header here | ||
| // forward declaring ModelPart adn Model to be avoid including heavy header here |
roigcarlo
reviewed
Oct 18, 2023
| * @param HalfZ The half-length of the cube in the Z-direction. | ||
| * @return ModelPart& The created cube skin model part. | ||
| */ | ||
| ModelPart& KRATOS_API(KRATOS_CORE) CreateCubeSkinModelPart( |
Member
There was a problem hiding this comment.
I believe that for individual functions has to be
KRATOS_API(KRATOS_CORE) ModelPart&
roigcarlo
reviewed
Oct 18, 2023
roigcarlo
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Code related to the creation of a cube skin model part (
CreateCubeSkinModelPart) and a cube model part (CreateCubeModelPart) were removed. Instead, theCppTestsUtilities::CreateCubeSkinModelPartandCppTestsUtilities::CreateCubeModelPartfunctions has been moved to theutilities/cpp_tests_utilities.hfile, and it is now used to create the model part.🆕 Changelog
CppTestsUtilitieswithCreateCubeSkinModelPartandCreateCubeModelPart