Merged
Conversation
loumalouomega
added
Cleanup
Kratos Core
FastPR
roigcarlo
approved these changes
Oct 17, 2023
Member
roigcarlo
left a comment
roigcarlo
left a comment
There was a problem hiding this comment.
Ok, but we should consider starting to remove the NodeType from Kratos
| using SizeType = std::size_t; | ||
|
|
||
| // Alias for representing node types in a mesh data structure. | ||
| using NodeType = TNodeType; |
Member
There was a problem hiding this comment.
We should delete this one an use Node directly.
Member
Author
There was a problem hiding this comment.
It is a template argument, IMHO we could remove all those templates or directly inegrate the mesh into the model part
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Minor clean up of
mesh.hfile, update header. Replacetypedefbyusing, among other minor clean ups.🆕 Changelog