[GeoMechanicsApplication] Moved logic of ApplyExcavationProcess to C++#11680
Merged
indigocoral merged 2 commits intomasterfrom Oct 14, 2023
Merged
[GeoMechanicsApplication] Moved logic of ApplyExcavationProcess to C++#11680indigocoral merged 2 commits intomasterfrom
indigocoral merged 2 commits intomasterfrom
Conversation
…ting in the apply_excavation_process.hpp file is split into .cpp and .hpp files
avdg81
reviewed
Oct 13, 2023
Contributor
avdg81
left a comment
avdg81
left a comment
There was a problem hiding this comment.
This looks nice and clean to me. I only have a few suggestions to make the code even better. Well done Marjan!
applications/GeoMechanicsApplication/custom_processes/apply_excavation_process.hpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_processes/apply_excavation_process.hpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_processes/apply_excavation_process.cpp
Outdated
Show resolved
Hide resolved
avdg81
approved these changes
Oct 13, 2023
Contributor
avdg81
left a comment
avdg81
left a comment
There was a problem hiding this comment.
Feel free to merge this one, Marjan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This class used to be defined partialy in Python module and in C++. In order to be able to use it in the settlement workflow, the logic is migrated from Python to C++.
🆕 Changelog