[Pip] Adding missing modules for packaging#11668
Merged
Conversation
jginternational
approved these changes
Oct 6, 2023
Member
jginternational
left a comment
jginternational
left a comment
There was a problem hiding this comment.
Tested by hand and seem to work
rubenzorrilla
approved these changes
Oct 6, 2023
Member
|
Ouch. True. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adding missing core modules for pip packaging. they were ignored by pip as they were not in the meta.
@rubenzorrilla We have to take this into account when we add new submodules. I forgot to check it in the PR.
🆕 Changelog
orchestratorsandmodelersto the list of allow core submodules.