Skip to content

[Core] Extend IntegrationUtilities to Compute Derivatives#11604

Merged
sunethwarna merged 5 commits intomasterfrom
core/integration_utilities/feature/derivatives
Sep 26, 2023
Merged

[Core] Extend IntegrationUtilities to Compute Derivatives#11604
sunethwarna merged 5 commits intomasterfrom
core/integration_utilities/feature/derivatives

Conversation

@sunethwarna
Copy link
Member

@sunethwarna sunethwarna commented Sep 25, 2023

📝 Description
This PR extends to have analytical derivative computations for methods IntegrationUtilities::ComputeArea2DGeometry and ComputeVolume3DGeometry namely IntegrationUtilities::ComputeArea2DGeometryDerivative and IntegrationUtilities::ComputeVolume3DGeometryDerivative.

This PR is required for #11571 .

PS: I think the whole IntegrationUtilities class can be divided into .h and .cpp even though there are some inlined methods. @roigcarlo @matekelemen

🆕 Changelog

  • Adds IntegrationUtilities::ComputeArea2DGeometryDerivative
  • Adds IntegrationUtilities::ComputeVolume3DGeometryDerivative
  • Adds tests

Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

sunethwarna and others added 2 commits September 25, 2023 17:01
Co-authored-by: Vicente Mataix Ferrándiz <vmataix@altair.com>
Co-authored-by: Vicente Mataix Ferrándiz <vmataix@altair.com>
loumalouomega
loumalouomega previously approved these changes Sep 25, 2023
Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@sunethwarna sunethwarna merged commit 811a999 into master Sep 26, 2023
@sunethwarna sunethwarna deleted the core/integration_utilities/feature/derivatives branch September 26, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants