[FastPR][Core] Adding HasPrototypeEntity to EntityIdentifier#11533
Merged
rubenzorrilla merged 3 commits intomasterfrom Sep 3, 2023
Merged
[FastPR][Core] Adding HasPrototypeEntity to EntityIdentifier#11533rubenzorrilla merged 3 commits intomasterfrom
rubenzorrilla merged 3 commits intomasterfrom
Conversation
rubenzorrilla
added
Kratos Core
FastPR
loumalouomega
approved these changes
Sep 1, 2023
Member
loumalouomega
left a comment
loumalouomega
left a comment
There was a problem hiding this comment.
I guess this is so simple we can live without test
loumalouomega
previously approved these changes
Sep 1, 2023
philbucher
reviewed
Sep 1, 2023
Member
philbucher
left a comment
philbucher
left a comment
There was a problem hiding this comment.
some design comments
Also test is missing
Member
Author
I didn't found any test for this utility. I'll create a new one. |
Member
Author
|
@philbucher I removed the pointer version and added a test in the last commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
On top of being handy, this is required to avoid the error thrown of the getter when using the EntityIdentifier in a context that mixes elements and conditions (see #11370 as an example).