Optapp/restructuring 23 gradient projection#11225
Merged
Conversation
…estructuring_23_gradient_projection
…estructuring_23_gradient_projection
…estructuring_23_gradient_projection
…g_22_steepest_descent
…estructuring_23_gradient_projection
…g_23_gradient_projection
sunethwarna
reviewed
Aug 7, 2023
Member
sunethwarna
left a comment
sunethwarna
left a comment
There was a problem hiding this comment.
Minor comments.
But please wait for #11454 before merging.
applications/OptimizationApplication/python_scripts/algorithms/algorithm_gradient_projection.py
Outdated
Show resolved
Hide resolved
applications/OptimizationApplication/python_scripts/algorithms/algorithm_gradient_projection.py
Outdated
Show resolved
Hide resolved
applications/OptimizationApplication/python_scripts/algorithms/standardized_constraint.py
Show resolved
Hide resolved
…/algorithm_gradient_projection.py Co-authored-by: Suneth Warnakulasuriya <suneth.warna@gmail.com>
Member
Author
|
@sunethwarna thnx for the review, let me know when I can merge. thnx |
Member
|
It is merged, so could you please merge master and resolve the conflicts. Then we will see what problems are there in this PR in windows compilation. |
RezaNajian
reviewed
Aug 18, 2023
Contributor
RezaNajian
left a comment
RezaNajian
left a comment
There was a problem hiding this comment.
@Igarizza thanks for the work. I can confidently say that this implementation is consistent with the reference.
applications/OptimizationApplication/python_scripts/algorithms/algorithm_gradient_projection.py
Show resolved
Hide resolved
RezaNajian
reviewed
Aug 19, 2023
| ], | ||
| "controls": [ | ||
| { | ||
| "name": "thickness_control", |
Contributor
There was a problem hiding this comment.
the model is solid model and thickness control should not be used.
Member
Author
There was a problem hiding this comment.
True, I have made a new example with shell elements.
applications/OptimizationApplication/python_scripts/algorithms/algorithm_gradient_projection.py
Outdated
Show resolved
Hide resolved
sunethwarna
reviewed
Aug 23, 2023
Member
sunethwarna
left a comment
sunethwarna
left a comment
There was a problem hiding this comment.
Nice, only minor comments from my side.
applications/OptimizationApplication/python_scripts/algorithms/algorithm_gradient_projection.py
Outdated
Show resolved
Hide resolved
applications/OptimizationApplication/python_scripts/algorithms/algorithm_gradient_projection.py
Outdated
Show resolved
Hide resolved
applications/OptimizationApplication/python_scripts/algorithms/standardized_constraint.py
Outdated
Show resolved
Hide resolved
…/standardized_constraint.py Co-authored-by: Suneth Warnakulasuriya <suneth.warna@gmail.com>
…/algorithm_gradient_projection.py Co-authored-by: Suneth Warnakulasuriya <suneth.warna@gmail.com>
…/algorithm_gradient_projection.py Co-authored-by: Suneth Warnakulasuriya <suneth.warna@gmail.com>
sunethwarna
previously approved these changes
Aug 23, 2023
Member
|
I think my suggested tabbing was wrong. You may have to check the tabbings of these. |
sunethwarna
previously approved these changes
Aug 24, 2023
…g_23_gradient_projection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Brings the new implementation of the Gradient Projection, following the main point from #11150 The implementation is based on the Haftka, where the correction is added directly to the design update and not to the search direction. Line search is applied to the projected direction. Two steps length are required: one for projected direction and one for size of the correction.
🆕 Changelog