fix: EXPOSED-754 Fix global rollback mark not set on unchecked exception in spring transaction#2453
Merged
bog-walk merged 5 commits intoJetBrains:mainfrom Dec 14, 2025
Merged
Conversation
6a2bf58 to
24b2145
Compare
bog-walk
approved these changes
Dec 14, 2025
Member
bog-walk
left a comment
There was a problem hiding this comment.
Thanks for recognizing this issue, the thorough PR, and pushing a fix @zbqmgldjfh !
Contributor
Author
|
Thank you for reviewing and merging the PR @bog-walk !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
isRollbackmanaged by TransactionScope in an individual transaction. :SpringTransactionManagerSpringTransactionRollbackTestDetailed description:
What: Global rollback mark not properly set on Unchecked Exception in Spring Transaction

Why: The issue arises when a method with a transaction is called more than once in a nested manner.
In this case, the results from the inner transactions are not being propagated to the outer one.
However, in Spring, it is the default behavior to mark the entire transaction for rollback.
Even if the exception is caught using a try-catch block, the rollback mark remains.
isRollbackproperty for TxType of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
Related Issues
https://youtrack.jetbrains.com/issue/EXPOSED-754/Global-Rollback-Mark-Not-Properly-Set-on-Unchecked-Exception-in-Spring-Transaction