Skip to content

[Bug] Fix threads parsing bugs#909

Merged
qrtt1 merged 1 commit intomainfrom
feature/sc-32473/fix-varaible-evaluation-bug
Oct 23, 2023
Merged

[Bug] Fix threads parsing bugs#909
qrtt1 merged 1 commit intomainfrom
feature/sc-32473/fix-varaible-evaluation-bug

Conversation

@qrtt1
Copy link
Contributor

@qrtt1 qrtt1 commented Oct 23, 2023

Fixes #907

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

bugfix

What this PR does / why we need it:

Make sure the threads is an integer value.

Which issue(s) this PR fixes:

sc-32473

Signed-off-by: Ching Yi, Chan <qrtt1@infuseai.io>
Co-authored-by: wcchang <wcchang@infuseai.io>
@qrtt1 qrtt1 force-pushed the feature/sc-32473/fix-varaible-evaluation-bug branch from 16bd1a3 to 4dd1591 Compare October 23, 2023 08:23
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #909 (4dd1591) into main (62890e7) will decrease coverage by 0.03%.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
- Coverage   47.97%   47.95%   -0.03%     
==========================================
  Files          77       77              
  Lines       10726    10739      +13     
==========================================
+ Hits         5146     5150       +4     
- Misses       5580     5589       +9     
Files Coverage Δ
piperider_cli/__init__.py 51.86% <50.00%> (-0.31%) ⬇️
piperider_cli/datasource/__init__.py 53.73% <0.00%> (-1.66%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qrtt1 qrtt1 merged commit ae7f51c into main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable to parse the threads property in profiles.yml

1 participant