Make gce endpoint strings configurable.#79
Merged
google-oss-prow[bot] merged 1 commit intoGoogleCloudPlatform:masterfrom Mar 9, 2023
Merged
Make gce endpoint strings configurable.#79google-oss-prow[bot] merged 1 commit intoGoogleCloudPlatform:masterfrom
google-oss-prow[bot] merged 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
bowei
reviewed
Mar 3, 2023
spencerhance
force-pushed
the
endpoint-vars
branch
2 times, most recently
from
b8edbc9 to
feabfbb
Compare
spencerhance
changed the title
bowei
reviewed
Mar 3, 2023
spencerhance
force-pushed
the
endpoint-vars
branch
from
feabfbb to
a4c62da
Compare
Member
|
add a unit test that checks the SetDomain took effect in the call to the API and this lgtm |
This will allow packages who import this to configure the endpoints to something like https://mydomain.com/compute/v1. These endpoints are only used for SelfLink().
spencerhance
force-pushed
the
endpoint-vars
branch
from
a4c62da to
8c2b775
Compare
Member
Author
Added a new test, lmk if that wasn't what you meant. |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow packages who import this to configure the endpoints to something like https://mydomain.com/compute/v1.
These endpoints are only used for SelfLink().