Added pfs-managed-lustre-slurm readme#5362
Added pfs-managed-lustre-slurm readme#5362siddhartha-quad wants to merge 1 commit intoGoogleCloudPlatform:developfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the documentation within the HPC Toolkit by integrating a new guide for deploying a high-performance compute cluster. The added content focuses on a blueprint that combines the Slurm Workload Manager with Google Cloud Managed Service for Lustre, aiming to provide users with clear instructions for setting up such an environment. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds documentation for the new pfs-managed-lustre-slurm.yaml example. The changes are good, but I have a few suggestions to improve the clarity and consistency of the instructions, particularly around the deployment and destruction commands. I've also pointed out a minor grammatical issue.
examples/README.md
Outdated
|
|
||
| This blueprint, managed-lustre-slurm, is a specialized configuration designed to deploy a high-performance compute cluster on Google Cloud. It integrates the Slurm Workload Manager with Google Cloud Managed Service for Lustre, a fully managed, POSIX-compliant parallel file system optimized for the massive I/O demands of AI/ML training and scientific simulations. | ||
|
|
||
| Creates a Managed Lustre file-system that is mounted in one of the slurm cluster controller instance. |
There was a problem hiding this comment.
There was a problem hiding this comment.
updated as per the suggestion
examples/README.md
Outdated
| To provision the cluster, Please run below command: | ||
|
|
||
| ``` | ||
| ./gcluster deploy examples/pfs-managed-lustre-slurm.yaml --vars "project_id=${GOOGLE_CLOUD_PROJECT}" | ||
| ``` |
There was a problem hiding this comment.
Since this is a multi-group deployment, it would be helpful to inform the user that they will be prompted to approve each group. Also, Please can be removed for a more direct tone, consistent with other examples.
| To provision the cluster, Please run below command: | |
| ``` | |
| ./gcluster deploy examples/pfs-managed-lustre-slurm.yaml --vars "project_id=${GOOGLE_CLOUD_PROJECT}" | |
| ``` | |
| To provision the cluster, run the following command. You will be prompted to approve each deployment group. | |
./gcluster deploy examples/pfs-managed-lustre-slurm.yaml --vars "project_id=${GOOGLE_CLOUD_PROJECT}"
There was a problem hiding this comment.
updated as per the suggestion
examples/README.md
Outdated
| To destroy the cluster, Please run below command: | ||
|
|
||
| ``` | ||
| ./gcluster destroy deployment_name | ||
| ``` |
There was a problem hiding this comment.
The placeholder deployment_name is ambiguous. For improved clarity, it's better to use a clear placeholder like <deployment_name> and explain what it refers to, which is a common pattern in this file.
| To destroy the cluster, Please run below command: | |
| ``` | |
| ./gcluster destroy deployment_name | |
| ``` | |
| To destroy the cluster, run the following command, replacing `<deployment_name>` with the name of your deployment (e.g. `managed-lustre-slurm`): | |
./gcluster destroy <deployment_name>
There was a problem hiding this comment.
updated as per the suggestion
a284288 to
636fe7e
Compare
636fe7e to
e723e56
Compare
This PR adds pfs-managed-lustre-slurm instructions in index readme
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.