feat: plumb optional auto monitoring scope

[jessicaochen]

Allow cluster toolkit to optionally specify the cluster auto monitoring scope. Not specifying it will default to current behavior.

Validated by setting up gke-a4.yaml without auto_monitoring_scope specified and with it auto_monitoring_scope=ALL. Checked the prior ended up with NONE (default) and the second with ALL for the scope.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

• Fork your PR branch from the Toolkit "develop" branch (not main)
• Test all changes with pre-commit in a local branch #
• Confirm that "make tests" passes all tests
• Add or modify unit tests to cover code changes
• Ensure that unit test coverage remains above 80%
• Update all applicable documentation
• Follow Cluster Toolkit Contribution guidelines #

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the GKE cluster module by providing an optional parameter to control the auto-monitoring scope for Managed Prometheus. This allows users to explicitly define whether all metrics or no metrics are automatically collected, offering greater flexibility in monitoring configurations for GKE clusters.

Highlights

• New auto_monitoring_scope variable: Introduced an optional auto_monitoring_scope variable to control Managed Prometheus auto-monitoring behavior in GKE clusters.
• Configurable Monitoring Scope: The new variable allows users to explicitly set the auto-monitoring scope to either 'ALL' or 'NONE' for GKE clusters.
• Example Configuration Update: An example GKE configuration (gke-a4.yaml) was updated to demonstrate the usage and default behavior of the new monitoring scope.

Changelog

• examples/gke-a4/gke-a4.yaml
  • Added auto_monitoring_scope variable with a default of "NONE"
  • Passed vars.auto_monitoring_scope to the gke-cluster module settings
• modules/scheduler/gke-cluster/README.md
  • Documented the new auto_monitoring_scope input variable, including its purpose, valid values, and default
• modules/scheduler/gke-cluster/main.tf
  • Configured the auto_monitoring_config block within managed_prometheus to use the auto_monitoring_scope variable
• modules/scheduler/gke-cluster/variables.tf
  • Defined the auto_monitoring_scope variable with type string, default "NONE", and validation to ensure values are either "ALL" or "NONE"

Activity

• No human activity has been recorded on this pull request since its creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces an optional auto_monitoring_scope variable to the GKE cluster module, allowing users to configure the scope for Managed Prometheus. The changes are well-implemented, including updates to the Terraform module, its variables, documentation, and a corresponding example blueprint. The new variable is properly validated, and the implementation is clean. Overall, this is a good addition that enhances the module's flexibility.

[aslam-quad]

/gcbrun

[jessicaochen]

I think I might not have permissions to add labels to PRs. Skimming the list, I think the following could be applicable:

• release-key-new-features
• release-module-improvements
• release-improvements