Skip to content

cry: propagate command failure#968

Merged
lisanna-dettwyler merged 1 commit intomasterfrom
lisanna/ci-win-mask
Nov 17, 2020
Merged

cry: propagate command failure#968
lisanna-dettwyler merged 1 commit intomasterfrom
lisanna/ci-win-mask

Conversation

@lisanna-dettwyler
Copy link
Contributor

Closes #953

@lisanna-dettwyler
Copy link
Contributor Author

The original issue was a spurious crash, likely a problem with the VM. I reproduced the masking behavior by passing an invalid target to cry build and observed bash continuing past it: https://github.com/GaloisInc/cryptol/runs/1408891733#step:8:65

The fix here is to make sure that the cry script correctly propagates build failures. I tested this fix with my original contrived reproducer and the build correctly fails at that step (after trying it 3 times): https://github.com/GaloisInc/cryptol/runs/1408908452#step:8:67

@lisanna-dettwyler lisanna-dettwyler merged commit 0943e98 into master Nov 17, 2020
@RyanGlScott RyanGlScott deleted the lisanna/ci-win-mask branch March 22, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI masks build failure

4 participants