Fix simplification rule for nested type-level exponentiation#1800
Merged
RyanGlScott merged 2 commits intomasterfrom Feb 11, 2025
Merged
Fix simplification rule for nested type-level exponentiation#1800RyanGlScott merged 2 commits intomasterfrom
RyanGlScott merged 2 commits intomasterfrom
Conversation
Previously, `Cryptol.TypeCheck.SimpType.tExp` would attempt to simplify `a ^^ (x ^^ y)` to `a ^^ (x * y)` at the type level, which was blatantly wrong. I have changed this to a similar (but actually valid) rule that simplified `(a ^^ x) ^^ y` to `a ^^ (x * y)`. (This law is normally stated with the condition that `a != 0`, but this law even works in Cryptol when `a == 0` due to the fact that `0 ^^ 0 == 1` in Cryptol.) Fixes #1799.
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mccleeary-galois
approved these changes
Feb 11, 2025
yav
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
Cryptol.TypeCheck.SimpType.tExpwould attempt to simplifya ^^ (x ^^ y)toa ^^ (x * y)at the type level, which was blatantly wrong. I have changed this to a similar (but actually valid) rule that simplified(a ^^ x) ^^ ytoa ^^ (x * y). (This law is normally stated with the condition thata != 0, but this law even works in Cryptol whena == 0due to the fact that0 ^^ 0 == 1in Cryptol.)Fixes #1799.