Merged
Conversation
This is necessary to ensure that `alex` and `happy` are located on the `PATH` when building GHC.
kquick
approved these changes
Jan 4, 2024
Member
kquick
left a comment
There was a problem hiding this comment.
Just a couple of suggestions for additional documentation.
We put these near the top of the Dockerfile alongside `GHCVER` to make it easier to remember to update them when `GHCVER` is updated.
c07147c to
5e0ea61
Compare
Contributor
Author
|
Sigh. I should have kicked off a separate, nightly pipeline to test my last commit, since it ended up being subtly incorrect. See this CI error: Judging from that error message, |
RyanGlScott
added a commit
that referenced
this pull request
Jan 5, 2024
Addresses the issue identified in #1600 (comment).
Member
|
No good deed... Been there, done that. C'est la vie, and all that bolderdash. :-) |
RyanGlScott
added a commit
that referenced
this pull request
Jan 5, 2024
…ge (#1601) Addresses the issue identified in #1600 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI fixes:
Switch from
haskell/actions/setuptohaskell-actions/setupFixes #1598.
Pin
alexto3.4.0.1incryptol-remote-apiDockerfileFixes #1599.