Copy the syntax-highlight directory under share/cyrptol for installation#1464
Copy the syntax-highlight directory under share/cyrptol for installation#1464
Conversation
RyanGlScott
left a comment
RyanGlScott
left a comment
There was a problem hiding this comment.
I've looked at a bindist for this PR and can confirm that the syntax highlighting files are included. I have one comment about the location of these files, but this otherwise LGTM.
| cp docs/*pdf $doc | ||
| mkdir -p $lib | ||
| cp -r lib/* $lib | ||
| cp -r syntax-highlight $lib |
There was a problem hiding this comment.
This will put the syntax-highlighting–related files among the .cry files, which is perhaps not the most intuitive place to put them. I wonder if it would make more sense to have a separate syntax-highlight/ subdirectory for this? Something like this, perhaps:
syntax_highlight=dist/share/syntax-highlight
...
mkdir -p $syntax_highlight
cp -r syntax-highlight $syntax_highlight
There was a problem hiding this comment.
Hm, I was hoping that since I don't have a slash after syntax-highlight it will copy the directory rather than the files in it... Did it not do that?
There was a problem hiding this comment.
It does copy the directory. What I am referring to is that you have a situation like this:
$ ls cryptol-2.13.0.99-ubuntu-22.04-x86_64/share/cryptol/
Array.cry Cryptol.cry Float.cry SuiteB.cry
Cryptol/ CryptolTC.z3 PrimeEC.cry syntax-highlight/
Perhaps this is what you intended, but I'm not sure that I would have thought to look here for the syntax-highlight directory. I'll let you make the call.
|
@RyanGlScott what do we want to do with this PR? Should we instead modify the scripts to get syntax-highlighting from the other repo? |
Yes, that sounds reasonable to me. |
2 participants
Add syntax highlighting to installation script