Update regression test for issue #835.#1417
Merged
RyanGlScott merged 1 commit intoGaloisInc:masterfrom Aug 26, 2022
taimoorzaeem:issue1329
Merged
Update regression test for issue #835.#1417RyanGlScott merged 1 commit intoGaloisInc:masterfrom taimoorzaeem:issue1329
RyanGlScott merged 1 commit intoGaloisInc:masterfrom
taimoorzaeem:issue1329
Conversation
Contributor
|
Thanks! By the way, for future reference: you don't need to open a new PR for each new change you make. Feel free to rebase your changes onto the same branch. This helps keeps the discussion for a particular task contained within a single PR, which makes it easier to review. |
Contributor
Author
Yeah sure! |
RyanGlScott
approved these changes
Aug 26, 2022
Contributor
RyanGlScott
left a comment
RyanGlScott
left a comment
There was a problem hiding this comment.
Happily, the CI passes this time. Let's land this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1329.