Merged
Conversation
RyanGlScott
force-pushed
the
ubuntu-22.04
branch
from
e86ef0c to
11fa39d
Compare
GitHub Actions has deprecated its Ubuntu 18.04 runners, and they will be removed by December 1, 2022. Moreover, GitHub Actions now offers Ubuntu 22.04 runners. It seems like a good time to upgrade our CI accordingly. Somewhat annoyingly, the `haskell` Docker images that we use in our Dockerfiles use such an old version of Debian that their version of `glibc` is incompatible with any of the `what4-solvers` built for Ubuntu 20.04 or 22.04. As a result, I switched them from the `haskell` Docker image to the `ubuntu` one. This required some minor tweaks to how dependencies are installed, but nothing too serious.
This is needed to work around https://gitlab.haskell.org/ghc/ghc/-/issues/20592 on macOS.
RyanGlScott
force-pushed
the
ubuntu-22.04
branch
from
11fa39d to
0d4b555
Compare
Contributor
Author
|
I also fired off a workflow-dispatched job here, which ensures that the nightly Docker-based jobs continue to build. |
kquick
reviewed
Aug 15, 2022
Member
kquick
left a comment
kquick
left a comment
There was a problem hiding this comment.
That glibc issue looks like it was annoying and had an unfortunately large impact on this changeset. Thanks for getting this taken care of!
RyanGlScott
added a commit
that referenced
this pull request
Oct 3, 2022
PR #1403 accidentally removed our build coverage for an older Ubuntu LTS configuration. This patch adds in back and ensures that we don't accidentally run the tests on this configuration.
RyanGlScott
added a commit
that referenced
this pull request
Oct 3, 2022
PR #1403 accidentally removed our build coverage for an older Ubuntu LTS configuration. This patch adds in back and ensures that we don't accidentally run the tests on this configuration.
RyanGlScott
added a commit
that referenced
this pull request
Oct 6, 2022
PR #1403 accidentally removed our build coverage for an older Ubuntu LTS configuration. This patch adds in back and ensures that we don't accidentally run the tests on this configuration.
yav
pushed a commit
that referenced
this pull request
Oct 13, 2022
PR #1403 accidentally removed our build coverage for an older Ubuntu LTS configuration. This patch adds in back and ensures that we don't accidentally run the tests on this configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions has deprecated its Ubuntu 18.04 runners, and they will be removed by December 1, 2022. Moreover, GitHub Actions now offers Ubuntu 22.04 runners. It seems like a good time to upgrade our CI accordingly.
Somewhat annoyingly, the
haskellDocker images that we use in our Dockerfiles use such an old version of Debian that their version ofglibcis incompatible with any of thewhat4-solversbuilt for Ubuntu 20.04 or 22.04. As a result, I switched them from thehaskellDocker image to theubuntuone. This required some minor tweaks to how dependencies are installed, but nothing too serious.