Conversation
RyanGlScott
reviewed
Jun 29, 2022
robdockins
reviewed
Jun 30, 2022
robdockins
reviewed
Jun 30, 2022
This reverts commit 20403c2.
This reverts commit 3456a7d.
Get rid of manual reference counting and fix leak where dlclose is not called if no symbols were successfully loaded
We didn't allow them anyway, but this gives a more precise error.
yav
approved these changes
Aug 8, 2022
Member
yav
left a comment
There was a problem hiding this comment.
Looks good to me. I made a few suggestion for stylistic improvements. On the topic of style, I really prefer the case expressions that do not use inverted indentation because it is quite a bit easier to see what is being matched where. For example like this:
I like:
function = some long prefix thing
case expr of
A -> thing1
B -> thing2
rather than:
function = some long prefix thing case expr of
A -> thing1
B -> thing2
rybla
reviewed
Aug 11, 2022
Bind foreign functions to a Cryptol runtime error instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a foreign function interface (FFI) to Cryptol. This allows Cryptol to call functions written in C.
For instance, we can declare this foreign function in Cryptol
and implement it in C
and then call it like any other Cryptol function.
See the FFI docs for more information.