Fix off-by-one error in What4 implementation of (@)#1361
Merged
RyanGlScott merged 2 commits intomasterfrom Jun 7, 2022
Merged
Conversation
These cases for `Z m` indices in the What4 implementation of `(@)` are unreachable by virtue of the fact that the index must be `Integral`. Let's remove them to make the code simpler. See #1359 (comment) for where this was originally noticed.
In the case where the index is a symbolic `Integer` and the sequence is of length `n`, the What4 backend mistakenly chose `n` to be the largest possible index. This corrects it to instead be `n - 1`. Fixes #1359.
robdockins
approved these changes
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where the index is a symbolic
Integerand the sequence is of lengthn, the What4 backend mistakenly chosento be the largest possible index. This corrects it to instead ben - 1.Fixes #1359.