Merged
Conversation
atomb
approved these changes
Sep 16, 2021
Contributor
atomb
left a comment
There was a problem hiding this comment.
I think this looks really nice, and should make simple scripts less noisy. The one CI failure is, I believe, and issue with the CVC4 binaries we're using. I'm looking into fixing it separately.
Contributor
|
Perhaps try rebasing/merging with |
Contributor
|
This PR should probably bump the client version and document what is added briefly in the CHANGELOG.md file. |
Contributor
Author
|
This should be ready to merge, the RPC bits of the CI have passed. The changes made in this latest batch of commits are:
|
pnwamk
reviewed
Sep 22, 2021
pnwamk
approved these changes
Sep 22, 2021
Contributor
Author
|
The CI passed for the second most recent commit, and the most recent commit just fixes a typo in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a single-connection interface for the python Cryptol RPC bindings based on the existing synchronous, typed interface. Since the argo server's default setting is to only allow a single connection at a time, this interface is a better fit for the expected use case of these bindings. The existing interfaces, where multiple
Connectionobjects can be created, still exist and are unchanged.Compared to the synchronous interface, this change lets us get rid of the "
c."s in front of every command. Compared to the old interface, this change also lets us get rid of the.result()calls and adds more types. For example, what was before:is now:
Link for comparing this interface to the old interface: 5a668a4...rpc/single-conn-interface (e.g. check out the test cases)