Merged
Conversation
This avoids an exponential slowdown that occurs with `layoutSmart` in combination with nested lists or lists of tuples. Fixes #1274.
The combinator is altered so that if a list item cannot be laid out on a single line, then we insert a linebreak before it so that it starts on its own line. Fixes #1275.
This was
linked to
issues
Sep 3, 2021
robdockins
approved these changes
Sep 5, 2021
Contributor
robdockins
left a comment
robdockins
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for figuring this out, none of the things I tried would work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are a couple of tweaks to the line-break heuristics in the prettyprinter. Awkward linebreaks that fall inside sub-expressions are now avoided. Here are some examples: