Build Docker images only on nightly runs#1271
Merged
Conversation
kquick
approved these changes
Aug 26, 2021
Member
kquick
left a comment
kquick
left a comment
There was a problem hiding this comment.
We already have confirmation this works from saw-script's similar change.
My only concern is that the schedule for Cryptol and Saw-Script are identical and these are probably largish jobs, so it might help CI resources to shift one of them by a half hour or an hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the CI workflows so that Docker images only get built during nightly builds, rather than on every PR.
The one failing test, for the RPC server, will likely be fixed shortly by some separate work @pnwamk is doing.