Merged
Conversation
This required a fair amount of fixup to the pretty-printing code, as some of the primitives have semantics that differ in subtle ways from the old package. The output now is mostly the same as before, although some improvements have been made here and there. The one somewhat negative outcome of this change is that the "line fill" algorithm in `prettyprinter` works a bit different and makes choices about where to break lines that are arguably less desirable than before. When laying out structures nested inside sequences, it is more likely to break a line inside a substructure, whereas the old algorithm prefered to break lines between elements of the outer sequence. There are also appear to be some minor differences regarding how ribbon width is calculated.
in the pretty printer code.
yav
approved these changes
Aug 9, 2021
Member
yav
left a comment
yav
left a comment
There was a problem hiding this comment.
I haven't had time to look at this but I am on PTO and I can't imagine there's anything interesting I'd have to say, so feel free to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap out the pretty printing library for
prettyprinter. This is a precursor to better pretty printer integration with the rest of our tools.