rpc: Move contents of __init__.py to new commands.py, connection.py files#1181
Merged
rpc: Move contents of __init__.py to new commands.py, connection.py files#1181
Conversation
pnwamk
reviewed
Apr 23, 2021
pnwamk
reviewed
Apr 23, 2021
pnwamk
approved these changes
Apr 23, 2021
Contributor
pnwamk
left a comment
pnwamk
left a comment
There was a problem hiding this comment.
I would add those two names to __all__ for consistency and then I think this is good if everything works unmodified (which it looks like it does).
atomb
approved these changes
Apr 26, 2021
Contributor
atomb
left a comment
atomb
left a comment
There was a problem hiding this comment.
Looks good to me, too. (I'm assuming that the large removal and addition chunks are just to move code, rather than change it, so I haven't looked at them carefully.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mirrors the organization of the SAW python bindings, and will enable us to export a new interface from
__init__.pywhich depends on the old. The exports of__init__.pyshould stay the same, so no scripts should have to be updated.