feat: notifications delay new request handling while running#183
Merged
feat: notifications delay new request handling while running#183
Conversation
0374aab to
28a00aa
Compare
28a00aa to
3749d49
Compare
Contributor
Author
|
This set of changes has two main consequences:
|
m-yac
reviewed
Aug 30, 2021
Contributor
m-yac
left a comment
There was a problem hiding this comment.
This looks awesome! I have a few questions, but they could just be due to me not having a full understanding of this codebase yet.
atomb
approved these changes
Aug 30, 2021
atomb
left a comment
There was a problem hiding this comment.
This looks good to me. I hope we don't need to keep the delay in the Python client for long, and can figure out how to remove the need on the server side, but I think it's okay to include for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it so that the handling of a notification cannot be interrupted/interleaved with new commands/queries/notifications. This may be enough to fix GaloisInc/cryptol#1261
Tweaking the default state eviction policy to remove older requests automatically instead of reject new ones if the server is full (thus removing the need for scripts to call
resetwhen connecting) may also be helpful.