Use exec in docker entrypoints to ensure bundler receives stop signals

[Almighty-Alpaca]

Currently when stopping a Docker Compose stack using docker compose stop/down Docker simply waits 10 seconds (default timeout) and then kills the contains. This happens because Bash is running as PID 1 inside the container. Bash receives the stop signal, but doesn't forward it to Dawarich. When using exec to start Dawarich, Dawarich replaces the Bash process instead of being spawned as a child and therefore receives all signals directly. See krallin/tini#8 (comment) for a really good explanation on signals in Docker.

Additionally, I escaped all variables and removed useless assignments. Previously, unquoted variable usages could lead to unwanted shell expansion (although it shouldn't have been a problem before when using "sane" inputs for the variables).

[Copilot]

Pull Request Overview

This PR updates the Docker entrypoint scripts to use exec when launching processes so that signals are forwarded properly, while also improving variable quoting and removing unnecessary assignments.

• Replaces Bash process with target processes via exec
• Consistently quotes variable usage to avoid unintended shell expansion
• Removes redundant environment variable assignments

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
docker/web-entrypoint.sh	Improves quoting of DATABASE_URL extractions and uses exec for signal handling
docker/sidekiq-entrypoint.sh	Similar quoting improvements with a minor inconsistency in quoting DATABASE_URL

Comments suppressed due to low confidence (1)

docker/sidekiq-entrypoint.sh:17

• For consistency and to prevent any unexpected word splitting, consider quoting DATABASE_URL as in the other assignments, for example: DATABASE_NAME=$(echo "$DATABASE_URL" | awk -F[@/] '{print $5}').

DATABASE_NAME=$(echo $DATABASE_URL | awk -F[@/] '{print $5}')

[Copilot]

Quoting the entire "${@}" may cause the arguments to be passed as a single string; consider using exec bundle exec "$@" to correctly separate multiple command arguments.

Suggested change

	exec bundle exec "${@}"
	exec bundle exec "$@"

[Almighty-Alpaca]

Copilot is wrong, see https://unix.stackexchange.com/a/129077

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Freika]

Thanks for contribution!