Conversation
feat: add country flag SVG icons (landscape and square variants)
Fix rubocop and biome linting issues
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughRuboCop configuration key changed and many cops disabled/excluded; miscellaneous formatting and inline comment tweaks in devcontainer, Gemfile, and app.json; CSS files reformatted and normalized (quotes, spacing, selector layout), with one stylesheet introducing a spacing change near Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (2)
.rubocop.yml (1)
28-35: Bulk-disabling all complexity/size metrics removes meaningful code quality signals.With
Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity,Metrics/BlockLength,Metrics/MethodLength,Metrics/ClassLength, andMetrics/ModuleLengthall disabled, RuboCop no longer enforces any complexity or size limits. Combined withMetrics/ParameterLists: Enabled: false(Line 34), this removes a meaningful layer of maintainability enforcement.Consider restoring at least some of these with elevated (rather than disabled) thresholds, or scoping exclusions to test/spec files where long methods are more acceptable.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.rubocop.yml around lines 28 - 35, The RuboCop config currently bulk-disables metrics (Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/BlockLength, Metrics/MethodLength, Metrics/ClassLength, Metrics/ModuleLength) and disables Metrics/ParameterLists; restore maintainability checks by re-enabling a subset of these rules with relaxed thresholds (e.g., raise Max for Metrics/CyclomaticComplexity and Metrics/PerceivedComplexity, increase Max for MethodLength/BlockLength/ClassLength) and/or scope strict enforcement to non-test files via an AllCops or Metrics namespace Exclude pattern; update the entries for Metrics/PerceivedComplexity, Metrics/ModuleLength, Metrics/ParameterLists and add explicit configuration blocks for Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength and Metrics/BlockLength to reflect the new thresholds or file excludes.Gemfile (1)
53-53: Nit: shortened comment loses diagnostic context.The original comment explained why sidekiq 8.1+ breaks Rails (it requires
connection_pool 3.0+). The new "breaking Rails" wording is vague and won't help future maintainers understand the constraint without cross-referencing Line 15's comment.✏️ Suggested wording
-gem 'sidekiq', '8.0.10' # Pin to 8.0.x - sidekiq 8.1+ requires connection_pool 3.0+ breaking Rails +gem 'sidekiq', '8.0.10' # Pin to 8.0.x - sidekiq 8.1+ requires connection_pool 3.0+ (breaking API changes with Rails RedisCacheStore)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Gemfile` at line 53, Restore the original diagnostic detail on the Sidekiq pin: update the comment on the line containing gem 'sidekiq', '8.0.10' to explicitly state that Sidekiq 8.1+ requires connection_pool 3.0+, which breaks compatibility with the project's Rails version, so keep the pin; include the specific "requires connection_pool 3.0+" rationale to aid future maintainers.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.rubocop.yml:
- Around line 73-74: The config currently disables the Rails/OutputSafety cop
which removes automated XSS checks; restore the cop by removing or reverting the
"Rails/OutputSafety: Enabled: false" entry and instead suppress only the
specific false-positive call sites (e.g., usages of html_safe, raw, concat) by
adding localized RuboCop directives around those lines (rubocop:disable/enable
Rails/OutputSafety) or by annotating those methods as safe, so the global cop
remains enabled while only known-safe instances are exempted.
- Around line 47-48: The RuboCop rule Rails/SkipsModelValidations is currently
disabled globally which is unsafe; re-enable the cop (remove or revert Enabled:
false) and instead add a scoped Exclude list for known safe locations where
validation-skipping is intentional (for example db/seeds.rb, db/migrate/**,
lib/tasks/** or specific data migration files), or document and prefer inline
rubocop:disable comments in those specific files; update the .rubocop.yml entry
for Rails/SkipsModelValidations to remove the global disable and include an
Exclude array listing those specific paths.
- Around line 54-60: Remove the blanket Exclude for the
Rails/ReversibleMigration and Rails/NotNullColumn cops in .rubocop.yml (the
entries under "Rails/ReversibleMigration: Exclude: - 'db/migrate/**/*'" and
"Rails/NotNullColumn: Exclude: - 'db/migrate/**/*'") and instead allow
violations to be suppressed inline per-migration using # rubocop:disable
comments; alternatively, if a narrower global exemption is required, restrict
the Exclude pattern to specific filenames rather than the entire db/migrate/**/*
directory so the cops continue to run on most migrations.
In `@app/assets/stylesheets/actiontext.css`:
- Around line 38-40: The comment in actiontext.css (the block comment above the
.trix-button-group.trix-button-group--file-tools rule) lacks a space before the
closing `*/`, causing Stylelint to fail; update that comment to include a space
before `*/` (i.e., change the comment text to end with a space before the
closing delimiter) so the file passes linting.
- Around line 21-36: The custom ActionText/Trix CSS rules (.trix-content,
.attachment-gallery, .attachment-gallery--2, .attachment-gallery--4,
action-text-attachment, .attachment) should either be replaced with equivalent
Tailwind/DaisyUI utilities (e.g., flex-basis/max-width responsive classes) to
comply with app/**/*.{css,scss,html,erb} guidelines, or—if these selectors are
required for ActionText output—add a brief justification comment above the block
explaining why bespoke CSS is necessary and ensure the block follows Tailwind
ordering conventions; update the file accordingly and keep the selector names
intact so Trix output continues to style correctly.
In `@app/assets/stylesheets/leaflet.control.layers.tree.css`:
- Around line 34-36: The removal of !important from the .leaflet-control-layers
label rule causes its 1.5rem line-height to be overridden by leaflet_theme.css's
1.25rem because asset loading order applies; to fix, either restore the
!important on .leaflet-control-layers label in leaflet.control.layers.tree.css
so the 1.5rem remains authoritative, or intentionally change the theme rule (in
leaflet_theme.css) to 1.5rem (or increase its selector specificity) if the
smaller line-height is not desired — update the rule for the selector
.leaflet-control-layers label accordingly to reflect the intended visual result.
---
Nitpick comments:
In @.rubocop.yml:
- Around line 28-35: The RuboCop config currently bulk-disables metrics
(Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity,
Metrics/BlockLength, Metrics/MethodLength, Metrics/ClassLength,
Metrics/ModuleLength) and disables Metrics/ParameterLists; restore
maintainability checks by re-enabling a subset of these rules with relaxed
thresholds (e.g., raise Max for Metrics/CyclomaticComplexity and
Metrics/PerceivedComplexity, increase Max for
MethodLength/BlockLength/ClassLength) and/or scope strict enforcement to
non-test files via an AllCops or Metrics namespace Exclude pattern; update the
entries for Metrics/PerceivedComplexity, Metrics/ModuleLength,
Metrics/ParameterLists and add explicit configuration blocks for
Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength and
Metrics/BlockLength to reflect the new thresholds or file excludes.
In `@Gemfile`:
- Line 53: Restore the original diagnostic detail on the Sidekiq pin: update the
comment on the line containing gem 'sidekiq', '8.0.10' to explicitly state that
Sidekiq 8.1+ requires connection_pool 3.0+, which breaks compatibility with the
project's Rails version, so keep the pin; include the specific "requires
connection_pool 3.0+" rationale to aid future maintainers.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (291)
app/assets/svg/icons/flags/landscape/ad.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ae.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/af.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ag.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ai.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/al.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/am.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ao.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/aq.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ar.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/arab.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/as.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/asean.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/at.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/au.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/aw.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ax.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/az.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ba.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bb.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bd.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/be.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bf.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bg.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bh.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bi.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bj.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bl.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bm.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bn.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bo.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bq.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/br.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bs.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bt.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bv.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bw.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/by.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/bz.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ca.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cc.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cd.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cefta.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cf.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cg.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ch.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ci.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ck.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cl.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cm.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cn.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/co.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cp.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cr.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cu.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cv.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cw.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cx.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cy.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/cz.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/de.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/dg.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/dj.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/dk.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/dm.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/do.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/dz.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/eac.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ec.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ee.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/eg.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/eh.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/er.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/es-ct.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/es-ga.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/es-pv.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/es.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/et.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/eu.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/fi.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/fj.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/fk.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/fm.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/fo.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/fr.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ga.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gb-eng.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gb-nir.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gb-sct.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gb-wls.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gb.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gd.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ge.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gf.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gg.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gh.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gi.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gl.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gm.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gn.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gp.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gq.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gr.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gs.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gt.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gu.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gw.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/gy.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/hk.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/hm.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/hn.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/hr.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ht.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/hu.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ic.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/id.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ie.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/il.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/im.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/in.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/io.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/iq.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ir.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/is.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/it.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/je.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/jm.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/jo.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/jp.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ke.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/kg.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/kh.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ki.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/km.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/kn.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/kp.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/kr.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/kw.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ky.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/kz.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/la.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/lb.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/lc.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/li.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/lk.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/lr.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ls.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/lt.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/lu.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/lv.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ly.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ma.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mc.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/md.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/me.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mf.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mg.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mh.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mk.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ml.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mm.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mn.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mo.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mp.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mq.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mr.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ms.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mt.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mu.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mv.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mw.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mx.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/my.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/mz.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/na.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/nc.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ne.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/nf.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ng.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ni.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/nl.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/no.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/np.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/nr.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/nu.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/nz.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/om.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/pa.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/pc.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/pe.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/pf.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/pg.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ph.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/pk.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/pl.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/pm.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/pn.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/pr.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ps.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/pt.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/pw.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/py.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/qa.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/re.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ro.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/rs.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ru.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/rw.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sa.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sb.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sc.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sd.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/se.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sg.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sh-ac.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sh-hl.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sh-ta.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sh.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/si.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sj.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sk.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sl.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sm.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sn.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/so.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sr.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ss.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/st.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sv.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sx.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sy.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/sz.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/tc.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/td.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/tf.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/tg.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/th.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/tj.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/tk.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/tl.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/tm.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/tn.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/to.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/tr.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/tt.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/tv.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/tw.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/tz.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ua.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ug.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/um.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/un.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/us.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/uy.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/uz.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/va.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/vc.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ve.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/vg.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/vi.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/vn.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/vu.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/wf.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ws.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/xk.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/xx.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/ye.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/yt.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/za.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/zm.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/landscape/zw.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/ad.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/ae.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/af.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/ag.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/ai.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/al.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/am.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/ao.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/aq.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/ar.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/arab.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/as.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/asean.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/at.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/au.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/aw.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/ax.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/az.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/ba.svgis excluded by!**/*.svgapp/assets/svg/icons/flags/square/bb.svgis excluded by!**/*.svg
📒 Files selected for processing (9)
.devcontainer/devcontainer.json.rubocop.ymlGemfileapp.jsonapp/assets/stylesheets/actiontext.cssapp/assets/stylesheets/application.cssapp/assets/stylesheets/leaflet.control.layers.tree.cssapp/assets/stylesheets/leaflet_theme.cssapp/assets/stylesheets/maps_maplibre_panel.css
Comment on lines
47
to
+48
| Rails/SkipsModelValidations: | ||
| Enabled: false |
There was a problem hiding this comment.
Disabling Rails/SkipsModelValidations globally is a data-integrity risk.
This cop catches uses of update_column, update_columns, update_all, upsert, insert_all, and similar methods that bypass ActiveRecord validations and callbacks. Disabling it project-wide silently allows these patterns everywhere, which can corrupt data in models with critical callbacks (e.g., password hashing, audit logging, normalizations).
Consider scoping the exclusion to specific files/directories where bypassing validations is intentional (e.g., data migrations, seed files) rather than disabling it globally.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.rubocop.yml around lines 47 - 48, The RuboCop rule
Rails/SkipsModelValidations is currently disabled globally which is unsafe;
re-enable the cop (remove or revert Enabled: false) and instead add a scoped
Exclude list for known safe locations where validation-skipping is intentional
(for example db/seeds.rb, db/migrate/**, lib/tasks/** or specific data migration
files), or document and prefer inline rubocop:disable comments in those specific
files; update the .rubocop.yml entry for Rails/SkipsModelValidations to remove
the global disable and include an Exclude array listing those specific paths.
Comment on lines
+54
to
+60
| Rails/ReversibleMigration: | ||
| Exclude: | ||
| - 'db/migrate/**/*' | ||
|
|
||
| Rails/NotNullColumn: | ||
| Exclude: | ||
| - 'db/migrate/**/*' |
There was a problem hiding this comment.
Excluding Rails/ReversibleMigration and Rails/NotNullColumn for the entire db/migrate/**/* directory removes critical safety guardrails.
Rails/ReversibleMigrationensures migrations can be rolled back — excluding it for all migrations meansrake db:rollbackbreakages won't be caught at review time.Rails/NotNullColumnprevents addingNOT NULLcolumns without defaults to tables with existing rows, which causes deployment failures in production.
These cops exist precisely to protect migration files. If specific migrations intentionally violate them, use inline # rubocop:disable comments instead of a blanket directory exclusion.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.rubocop.yml around lines 54 - 60, Remove the blanket Exclude for the
Rails/ReversibleMigration and Rails/NotNullColumn cops in .rubocop.yml (the
entries under "Rails/ReversibleMigration: Exclude: - 'db/migrate/**/*'" and
"Rails/NotNullColumn: Exclude: - 'db/migrate/**/*'") and instead allow
violations to be suppressed inline per-migration using # rubocop:disable
comments; alternatively, if a narrower global exemption is required, restrict
the Exclude pattern to specific filenames rather than the entire db/migrate/**/*
directory so the cops continue to run on most migrations.
Comment on lines
+73
to
+74
| Rails/OutputSafety: | ||
| Enabled: false |
There was a problem hiding this comment.
Disabling Rails/OutputSafety degrades XSS protection.
Rails/OutputSafety flags unsafe uses of html_safe, raw, and concat that can introduce XSS vulnerabilities. Disabling it means code reviewers lose automated detection of potentially unsafe HTML interpolation. If there are specific known-safe call sites triggering false positives, those should be suppressed inline rather than turning the cop off globally.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.rubocop.yml around lines 73 - 74, The config currently disables the
Rails/OutputSafety cop which removes automated XSS checks; restore the cop by
removing or reverting the "Rails/OutputSafety: Enabled: false" entry and instead
suppress only the specific false-positive call sites (e.g., usages of html_safe,
raw, concat) by adding localized RuboCop directives around those lines
(rubocop:disable/enable Rails/OutputSafety) or by annotating those methods as
safe, so the global cop remains enabled while only known-safe instances are
exempted.
Comment on lines
+21
to
36
| .trix-content | ||
| .attachment-gallery.attachment-gallery--2 | ||
| > action-text-attachment, | ||
| .trix-content .attachment-gallery.attachment-gallery--2 > .attachment, | ||
| .trix-content | ||
| .attachment-gallery.attachment-gallery--4 | ||
| > action-text-attachment, | ||
| .trix-content .attachment-gallery.attachment-gallery--4 > .attachment { | ||
| flex-basis: 50%; | ||
| max-width: 50%; | ||
| } | ||
|
|
||
| .trix-content action-text-attachment .attachment { | ||
| padding: 0 !important; | ||
| max-width: 100% !important; | ||
| padding: 0; | ||
| max-width: 100%; | ||
| } |
There was a problem hiding this comment.
Use Tailwind/DaisyUI utilities or justify bespoke CSS here.
These modified rules are bespoke CSS inside app assets; if this is unavoidable for ActionText/Trix output, please add a brief justification comment or move styling to Tailwind/DaisyUI utilities where feasible.
As per coding guidelines: “app//*.{css,scss,html,erb}: Use Tailwind + DaisyUI for styling” and “app//*.{css,scss}: Follow Tailwind ordering conventions and avoid bespoke CSS unless necessary.”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@app/assets/stylesheets/actiontext.css` around lines 21 - 36, The custom
ActionText/Trix CSS rules (.trix-content, .attachment-gallery,
.attachment-gallery--2, .attachment-gallery--4, action-text-attachment,
.attachment) should either be replaced with equivalent Tailwind/DaisyUI
utilities (e.g., flex-basis/max-width responsive classes) to comply with
app/**/*.{css,scss,html,erb} guidelines, or—if these selectors are required for
ActionText output—add a brief justification comment above the block explaining
why bespoke CSS is necessary and ensure the block follows Tailwind ordering
conventions; update the file accordingly and keep the selector names intact so
Trix output continues to style correctly.
Comment on lines
38
to
+40
| /* Hide both attach files and attach images buttons in trix editor*/ | ||
| .trix-button-group.trix-button-group--file-tools { | ||
| display:none; | ||
| display: none; |
There was a problem hiding this comment.
Fix comment whitespace to satisfy lint.
Stylelint expects a space before */ in the comment.
🔧 Proposed fix
-/* Hide both attach files and attach images buttons in trix editor*/
+/* Hide both attach files and attach images buttons in trix editor */📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| /* Hide both attach files and attach images buttons in trix editor*/ | |
| .trix-button-group.trix-button-group--file-tools { | |
| display:none; | |
| display: none; | |
| /* Hide both attach files and attach images buttons in trix editor */ | |
| .trix-button-group.trix-button-group--file-tools { | |
| display: none; |
🧰 Tools
🪛 Stylelint (17.3.0)
[error] 38-38: Expected whitespace before "*/" (comment-whitespace-inside)
(comment-whitespace-inside)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@app/assets/stylesheets/actiontext.css` around lines 38 - 40, The comment in
actiontext.css (the block comment above the
.trix-button-group.trix-button-group--file-tools rule) lacks a space before the
closing `*/`, causing Stylelint to fail; update that comment to include a space
before `*/` (i.e., change the comment text to end with a space before the
closing delimiter) so the file passes linting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Style
Bug Fixes