Support different working directories for data#7
Merged
erickjung merged 9 commits intoFarfetch:masterfrom May 27, 2021
guilherme-fh:master
Merged
Support different working directories for data#7erickjung merged 9 commits intoFarfetch:masterfrom guilherme-fh:master
erickjung merged 9 commits intoFarfetch:masterfrom
guilherme-fh:master
Conversation
rodrigowoulddo
approved these changes
May 26, 2021
erickjung
requested changes
May 26, 2021
erickjung
approved these changes
May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
chooseFoldermethod toUtilsto give support to directory selectionworkingDirectorythat is defined according to what's set on thedataFolder.json(or else defaults to the root directory). Upon setting a newworkingDirectorythedataFolder.jsonis updated accordinglyworkingDirectoryDescription
This PR intends to give support to different working directories to access the data and test files.
Its purpose is to allow git synchronisation of these files, a feature that useful when working with teams.
Motivation and Context
This PR intends to ease synchronisation of data and test files among large (or even small) teams
Types of changes
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement