Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we checked if there were multiple resolved dependencies with the same name and marked them as duplicates, and thus did an additional version check when resolving edges so that the correct duplicate version was selected, however this didn't account for cases where the dependency was not actually resolved by cargo due to feature selection (and possibly kind eg dev), which could cause the incorrect dependency to be selected. This makes it so we eat the cost of parsing the semver and just always match on it, which is unfortunate, but gets rid of this edge case and potentially others.
Resolves: #74